Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev -> main #72

Merged
merged 2 commits into from
Feb 21, 2024
Merged

dev -> main #72

merged 2 commits into from
Feb 21, 2024

Conversation

Starlight258
Copy link
Collaborator

πŸ”— Linked Issue

  • #-

πŸ“‹ Code Review Priority Guideline

  • 🚨 P1: Request Change
    • ν•„μˆ˜ 반영: κΌ­ λ°˜μ˜ν•΄μ£Όμ‹œκ³ , 적극적으둜 κ³ λ €ν•΄μ£Όμ„Έμš” (수용 ν˜Ήμ€ ν† λ‘ ).
  • πŸ’¬ P2: Comment
    • ꢌμž₯ 반영: μ›¬λ§Œν•˜λ©΄ λ°˜μ˜ν•΄μ£Όμ„Έμš”.
  • πŸ‘ P3: Approve
    • 선택 반영: λ°˜μ˜ν•΄λ„ μ’‹κ³  λ„˜μ–΄κ°€λ„ μ’‹μŠ΅λ‹ˆλ‹€. κ·Έλƒ₯ μ‚¬μ†Œν•œ μ˜κ²¬μž…λ‹ˆλ‹€.

Starlight258 and others added 2 commits February 22, 2024 01:09
@Starlight258
[#-] fix: Add allowed origin to fix CORS error
07ba05c
@Starlight258
Merge pull request #71 from dnd-side-project/feat/debug
570f471 
[Fix/#-] CORS μ—λŸ¬ μˆ˜μ •μ„ μœ„ν•΄ allowed origin μΆ”κ°€
@Starlight258 Starlight258 added this to the Sprint 4 milestone Feb 21, 2024
@Starlight258 Starlight258 self-assigned this Feb 21, 2024
FacerAin
FacerAin approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@FacerAin FacerAin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@FacerAin FacerAin merged commit a13cdca into main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FacerAin FacerAin FacerAin approved these changes

Assignees

@Starlight258 Starlight258

Labels
🚩 Priority: High πŸ› Type: Bug ✨ Type: Enhancement
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.
2 participants
@Starlight258 @FacerAin