Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix delete stomp connection #87

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: fix delete stomp connection #87

merged 1 commit into from
Nov 21, 2024

Conversation

FacerAin
Copy link
Collaborator

๐Ÿ”— Linked Issue

resolved: #1 #2

๐Ÿ›  ๊ฐœ๋ฐœ ๊ธฐ๋Šฅ

  • ๊ฐœ๋ฐœํ•œ ๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ๊ฐ„๋žตํ•œ ์„ค๋ช…์„ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿงฉ ํ•ด๊ฒฐ ๋ฐฉ๋ฒ•

  • ๋ฌธ์ œ๋ฅผ ์–ด๋–ป๊ฒŒ ํ•ด๊ฒฐํ–ˆ๋Š”์ง€ ๊ฐ„๋žตํ•˜๊ฒŒ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

๐Ÿ” ๋ฆฌ๋ทฐ ํฌ์ธํŠธ

  • ๋ฆฌ๋ทฐ ์‹œ ์–ด๋–ค ๋ถ€๋ถ„์— ์ง‘์ค‘ํ•ด์•ผ ํ• ์ง€ ๋ช…์‹œํ•ด์ฃผ์„ธ์š”.

๐Ÿ“‹ Code Review Priority Guideline

  • ๐Ÿšจ P1: Request Change
    • ํ•„์ˆ˜ ๋ฐ˜์˜: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์‹œ๊ณ , ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (์ˆ˜์šฉ ํ˜น์€ ํ† ๋ก ).
  • ๐Ÿ’ฌ P2: Comment
    • ๊ถŒ์žฅ ๋ฐ˜์˜: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š”.
  • ๐Ÿ‘ P3: Approve
    • ์„ ํƒ ๋ฐ˜์˜: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค. ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค.

@FacerAin FacerAin self-assigned this Nov 21, 2024
@FacerAin FacerAin merged commit 26c17c1 into dnd-side-project:main Nov 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FacerAin FacerAin

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@FacerAin