Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Install: Move module out of PolyDeploy folder and rename a few base project files #5966

Merged

Conversation

david-poindexter
Copy link
Contributor

Summary

This is the first of many PRs in support of #5920

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is mostly a move/rename of files but the build is failing and I could not quickly find out why from the logs here. @david-poindexter do you see more details when doing a full build locally or it just works fine?

@david-poindexter
Copy link
Contributor Author

@valadas I am pretty sure the project didn't build correctly before. We just didn't see it because it had not been added to the DNN_Platform.sln. I was honestly expecting the build to fail until we get a lot of this project converted to the new namespace, etc. How would you like for me to handle this? I can do one of the following:

  • Remove the project from the solution for now.
  • Try to make a much larger PR and get the project to compile.

If you have another idea, I am open to that as well.

@david-poindexter
Copy link
Contributor Author

Okay, I just verified. The project was unable to build successfully before my changes, so would you like for me to remove it from the solution, or we ignore the build issues for now?

@valadas
Copy link
Contributor

valadas commented Feb 10, 2024

Ok sounds good. Unless anyone disagrees so we can work faster on this, only on this (feature) branch we will work with one reviewer and backpedal only if needed. We will then follow the branch rules when we merge the whole bulk-install feature in a protected branch (release/10.0.0 for instance).

Until we get farther along it is kinda normal to get build failures here.

@valadas valadas merged commit e8c131a into dnnsoftware:feature/bulk-install Feb 10, 2024
3 of 4 checks passed
@david-poindexter david-poindexter deleted the bulk-install-project branch February 10, 2024 03:15
@david-poindexter david-poindexter changed the title Move module out of PolyDeploy folder and rename a few base project files Bulk Install: Move module out of PolyDeploy folder and rename a few base project files Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants