Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --wait or --watch capabilities to **depends_on**, avoiding configuration of healthchecks for simple use cases #12428

Open
esauvisky opened this issue Jan 2, 2025 · 2 comments

Comments

@esauvisky
Copy link

Description

Sometimes, we need to wait a bit after launching a container before starting a container that relies on it, as services may take time to boot up. The proper approach is to set a healthcheck and use that as the sign that the dependency is genuinely ready for the dependent service to start. However, healthchecks can be quite complicated and hard to implement in every case, making it much easier if we could just pause for a few seconds before starting the dependent service.

With the introduction of the (relatively) new features --wait and --watch, I propose we expand their capabilities to include the depends_on feature.

@esauvisky esauvisky changed the title Introduce --wait or --watch functionality to **depends_on**, eleminating the need to configure healthchecks. Introduce --wait or --watch functionality to **depends_on**, eleminating the need to configure healthchecks for simple scenarios Jan 3, 2025
@esauvisky esauvisky changed the title Introduce --wait or --watch functionality to **depends_on**, eleminating the need to configure healthchecks for simple scenarios Introduce --wait or --watch functionality to depends_on, eleminating the need to configure healthchecks for simple scenarios Jan 3, 2025
@esauvisky esauvisky changed the title Introduce --wait or --watch functionality to depends_on, eleminating the need to configure healthchecks for simple scenarios Introduce --wait or --watch capabilities to **depends_on**, avoiding configuration of healthchecks for simple use cases Jan 3, 2025
@tchavei
Copy link

tchavei commented Jan 3, 2025

Indeed that would be a excellent quality of life improvement. I have several containers that "depend on" other containers but sometimes they still start too quickly before the preceding container finishes loading the app. A timer or delay would be invaluable.

Great idea!

@ndeloof
Copy link
Contributor

ndeloof commented Jan 6, 2025

they still start too quickly before the preceding container finishes loading the app

This is exactly what healthcheck is about. Sounds pretty easy to configure a healthcheck to run curl localhost... waiting for app to return a 200 HTTP result

healthchecks can be quite complicated and hard to implement in every case, making it much easier if we could just pause for a few seconds before starting the dependent service.

Sounds to me this proposal is a bad workaround for such a situation. Writing a basic healthcheck script should not be that hard, do you have any example in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants