Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

docker-compose version 2.1 (v2.1) #441

Closed
vito-c opened this issue Feb 22, 2017 · 12 comments
Closed

docker-compose version 2.1 (v2.1) #441

vito-c opened this issue Feb 22, 2017 · 12 comments

Comments

@vito-c
Copy link
Contributor

vito-c commented Feb 22, 2017

I just changed the version from:

version: '2'
services:

to

version: '2.1'
services:

and I get the following error:

ERRO[0000] Could not parse config for project libcompose : yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2.1` into config.RawService
panic: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2.1` into config.RawService

Are there plans to support version 2.1 in the future? There are some important features added to the compose file healthcheck and depends_on was improved.

@vdemeester
Copy link
Collaborator

@vito-c yes there is 👼 Just lagging behind quite a bit (running a little bit out of time 😅)

@vito-c
Copy link
Contributor Author

vito-c commented Feb 22, 2017

I would love to help is there a branch? or does it need to be implemented from scratch?

@vito-c
Copy link
Contributor Author

vito-c commented Feb 28, 2017

@vdemeester anything I can do to help?

@joshwget
Copy link
Contributor

It sounds like the changes to depends_on aren't supported in v3 anymore (https://github.com/docker/compose/blob/master/CHANGELOG.md#compose-file-version-21-and-up). Is it worth working on this feature still?

@vito-c
Copy link
Contributor Author

vito-c commented Mar 1, 2017

@joshwget backwards compatibility is important.

I'm also a little confused by the decision to drop support for depends_on and healthchecks I haven't really heard a good argument for doing so.

@yelvert
Copy link

yelvert commented Sep 24, 2017

+1

@jwreagor
Copy link

jwreagor commented Oct 11, 2017

I've started working on some of this in my spare time. In order to begin the support of more compose file versions (#474, #490) I hope to continue refactoring between when the compose file is parsed and when it is validated by JSON schema. I think that should at least bump this up to '2.1'.

I'll try to post something up early to see what the original authors think. Cheers.

@joyel24
Copy link

joyel24 commented Oct 23, 2017

+1 for support 2.1 yml

@ghost
Copy link

ghost commented Nov 11, 2017

I think we also need 2.2 schema support

@donbobka
Copy link

+1 version 2.3

@lpalgarvio
Copy link

lpalgarvio commented Jan 8, 2018

@CpuID
Copy link
Contributor

CpuID commented Aug 21, 2018

Good to close thanks to #507 (I think).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants