-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on initial load of slider if we click on first dot with stopAutoPlayOnSlide set as false, it stops working correctly(note: this happens only when slider just loads and hasn't removed hide-slides class from remaining slides) #38
Comments
@SachinB123 thank you for finding this! When you say "stops working correctly," do you mean that it stops auto-playing even though it should not? |
No, whether it autoplays or not that is not the issue. This issue can be reproduced on your demo page in following steps: Note: Problem only occurs in initial or first round of slide traversal using dots only but not with arrows, arrows based traversal works fine. Only possible solution, I could find for this is that initially, not loaded slides are hidden using 'hide-slide' class, so I removed them and in their place I added 'right-slide' class that you had inside your package with left:100% defined which solved it temporarily but since it is an issue so I opened it here. |
@SachinB123 thank you for this information. I will likely not have time to look into this until this weekend, but I will let you know once I have it resolved. |
Update: still trying to figure this out. Will look into it more this week. |
This could use a fix |
I think this might just be fixed now, need to verify |
it's definitely not fixed. Will try to investigate tomorrow. another problem I see is that on lazy load it first loads the first image, and then after you slide to another image it loads all other images in one go. |
Okay, I have a solution. How can I push it? |
@bttb that's awesome! Just make a PR. FYI: the original intention of |
on initial load of slider if we click on first dot after it has moved to second or third dot with stopAutoPlayOnSlide set as false, it stops working correctly(note: this happens only when slider just loads and hasn't removed 'hide-slide' class from remaining slides).
A proposed solution would be to remove 'hide-slide' class and instead just provide those non selected class with 'right-slide' class but of course this is proposed as temporary hack and it would be better if you resolved it in your package internally
The text was updated successfully, but these errors were encountered: