From ee10db8ad5349f1f591fb0663b4b8a622a64be12 Mon Sep 17 00:00:00 2001 From: Jashon Osala Date: Tue, 28 Nov 2023 11:58:51 +0300 Subject: [PATCH 1/2] fix: Make signin form recorgnizable by password managers. --- web/utils/layout.py | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/web/utils/layout.py b/web/utils/layout.py index aa893571..14752e7c 100644 --- a/web/utils/layout.py +++ b/web/utils/layout.py @@ -260,23 +260,24 @@ def __login_form() -> None: st.markdown("### Please login to continue") form_validator, form_name = st.empty(), "login-form" - username = st.text_input("Username", value="", key="login_username") - password = st.text_input("Password", value="", key="login_password", type="password") - if st.button("Login"): - if handle_login(username, password): - st.experimental_rerun() - elif not handle_check_account_activated(username): - st.session_state[f"{form_name}-resend-verification-email"] = True + with st.form(key=form_name): + username = st.text_input("Username", value="", key="login_username", autocomplete="username") + password = st.text_input("Password", value="", key="login_password", type="password", autocomplete="current-password") + if st.form_submit_button("Login"): + if handle_login(username, password): + st.experimental_rerun() + elif not handle_check_account_activated(username): + st.session_state[f"{form_name}-resend-verification-email"] = True + else: + form_validator.error("The Username or the Password you've entered doesn't match what we have.") + st.stop() + + if st.session_state.get(f"{form_name}-resend-verification-email", False): + with form_validator.container(): + __resend_verification_ui(username, form_name) else: - form_validator.error("The Username or the Password you've entered doesn't match what we have.") st.stop() - if st.session_state.get(f"{form_name}-resend-verification-email", False): - with form_validator.container(): - __resend_verification_ui(username, form_name) - else: - st.stop() - def __logout_button() -> None: sidebar = st.sidebar From 64b60bff851a434f8f5977757b31f3261d5cd7fe Mon Sep 17 00:00:00 2001 From: Jashon Osala Date: Tue, 28 Nov 2023 12:11:59 +0300 Subject: [PATCH 2/2] chore: Make signup form recorgnizable to password generators. --- web/utils/layout.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web/utils/layout.py b/web/utils/layout.py index 14752e7c..07030ce1 100644 --- a/web/utils/layout.py +++ b/web/utils/layout.py @@ -1390,13 +1390,14 @@ def signup_ui() -> None: st.session_state[f"{form}-validator"] = st.empty() with st.form(key=form): - st.text_input("Name", placeholder="Bob Smith", key=f"{form}-name", value=qs_name) - st.text_input("Email", placeholder="bob.smith@acme.com", key=f"{form}-email", value=qs_email, disabled=qs_email is not None) + st.text_input("Name", placeholder="Bob Smith", key=f"{form}-name", value=qs_name, autocomplete="name") + st.text_input("Email", placeholder="bob.smith@acme.com", key=f"{form}-email", value=qs_email, disabled=qs_email is not None, autocomplete="email") st.text_input( "Password", type="password", key=f"{form}-password", - help="Password must be at least 8 characters long and contain at least 1 lowercase letter, 1 uppercase letter, 1 number and 1 special character." + help="Password must be at least 8 characters long and contain at least 1 lowercase letter, 1 uppercase letter, 1 number and 1 special character.", + autocomplete="new-password", ) submit = st.form_submit_button("Signup") if submit: