forked from karask/python-bitcoin-utils
-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathTODO
48 lines (40 loc) · 2.28 KB
/
TODO
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
SEGWIT-related
- create TxInputWitness class that includes the witness script and knows how to serialize itself and how to calc byte length (for get_vsize)
- segwit txs are valid but they are not identical to those that bitcoin core creates; there seems to be a difference in the signature calculation
. this is because from bitcoin core v0.17 all signatures need to have low R (in addition to low S)
. https://bitcoin.stackexchange.com/questions/88702/why-is-a-librarys-signature-of-a-segwit-tx-different-from-bitcoin-core-signatur
. Apparently this could happen to non-segwit transactions as well... need to fix the signature construction
- explain get_transaction_segwit_digest() better and test further
- clean and comment the segwit examples !
. test some more segwit txs including nested ones
PSBT
- add!
DOC-related
- add explicit documentation for each module before members...
- commit docs/usage/proxy.rst
- add segwit examples in README
- segwit in documentation
- add more modules to documantation
CODE-related
- make all code < 80 chars !?
- improve test structure - look at python-bitcoinlib or its derived python-bitcointx for example
Efficiency
- make all internal variables bytes for processing and convert when input (hex usually) or output (displaying hex usually)
. hmm, only applies fot Addresses' classes
WINDOWS
- it seems that the default port does not work on windows; need to specify the port explicitly in NodeProxy
OTHERLIBS-related
- add to bitcoin-rpc lib option to ignore invalid ssl cert
. needed to access remotely withut cert (for other validators from clients)
. https://github.com/jgarzik/python-bitcoinrpc/pull/50
. but not in a lib release yet
. add config.ini option to optionally ignore cert so that it works when calling btcd remotely
OTHER
- reminder: update copyright in all files 2018-2021?
- create script: clean-less-than-sats 100000 bc1q86gsg4t32...
- create test with 260 outputs (inputs too much trouble) - file: test_extreme_txs.py
- create test with script of 260 and another with 66000 commands
- make test of send to P2WPKH transaction example
- bitcoin inputs/outputs number is compact size/var int... not a single byte -- fix
. currently we allow only 256 I/Os
. make sure to update all varints - https://en.bitcoin.it/wiki/File:TxBinaryMap.png