-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new reporting system #183
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalloc
force-pushed
the
report-builder
branch
2 times, most recently
from
November 23, 2020 02:30
ef705ac
to
7fbb02a
Compare
koden-km
reviewed
Nov 23, 2020
koden-km
reviewed
Nov 23, 2020
koden-km
reviewed
Nov 23, 2020
jmalloc
changed the title
Add
Add new reporting system
Nov 23, 2020
Finding
and its associated types.
jmalloc
force-pushed
the
report-builder
branch
from
November 25, 2020 07:13
1d30b59
to
2c99294
Compare
jmalloc
force-pushed
the
report-builder
branch
8 times, most recently
from
November 28, 2020 09:15
03c9787
to
cf97f8d
Compare
Co-authored-by: Kevin Millar <[email protected]>
jmalloc
force-pushed
the
report-builder
branch
from
November 28, 2020 09:55
cf97f8d
to
32f7b56
Compare
jmalloc
force-pushed
the
report-builder
branch
from
November 28, 2020 10:05
32f7b56
to
940e4c3
Compare
jmalloc
force-pushed
the
report-builder
branch
from
November 28, 2020 21:12
523ecbe
to
38bd172
Compare
jmalloc
force-pushed
the
report-builder
branch
from
November 28, 2020 21:18
a8eca22
to
4645240
Compare
jmalloc
force-pushed
the
report-builder
branch
from
November 28, 2020 22:17
4302071
to
fb5cbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
This PR adds the
report.Report
type and several associated types which represent a human-readable report about the activity within and final result of a test.What issues does this relate to?
Why make this change?
To allow for a consist report building and rendering experience regardless of whether the test result was determined by an
Expectation
or by some other occurrence.Is there anything you are unsure about?
No