Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the script hook for peerDepInstall task #202

Open
agubler opened this issue Sep 4, 2017 · 0 comments
Open

Change the script hook for peerDepInstall task #202

agubler opened this issue Sep 4, 2017 · 0 comments

Comments

@agubler
Copy link
Member

agubler commented Sep 4, 2017

Currently dojo2 packages use the prepubish to run the grunt task that installs peer dependencies.

As of npm5 this hook it deprecated, we need to find a new hook (or hooks) to run the peer dependency grunt task.

We should consider the prepare hook, but we cannot just swap if we want to still support npm 3+ as the hook was only introduced in npm4

@kitsonk kitsonk added this to the 2017.09 milestone Sep 4, 2017
@dylans dylans modified the milestones: 2017.09, 2017.10 Sep 26, 2017
@kitsonk kitsonk removed the beta3 label Oct 30, 2017
@kitsonk kitsonk removed this from the 2017.10 milestone Oct 30, 2017
@kitsonk kitsonk added the beta5 label Oct 30, 2017
@kitsonk kitsonk added this to the beta.5 milestone Oct 30, 2017
@agubler agubler removed the beta5 label Jan 4, 2018
@agubler agubler removed this from the beta.5 milestone Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants