Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure the Central<->Buildbot change submission path #172

Open
delroth opened this issue Jan 17, 2023 · 1 comment
Open

Secure the Central<->Buildbot change submission path #172

delroth opened this issue Jan 17, 2023 · 1 comment

Comments

@delroth
Copy link
Member

delroth commented Jan 17, 2023

Currently the change submission path via the Buildbot webhook API is not properly authenticated, and this could be an abusable flaw. Once Buildbot is moved to altair and modernized, add a new webhook parser plugin which supports some kind of HMAC signature, or at the very least something like HTTP basic auth.

(I think we might actually be able to do HTTP basic auth already as a stopgap, but haven't tried.)
@OatmealDome
Copy link
Member

Forgot to update this issue - I implemented HTTP basic authentication as a stopgap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delroth @OatmealDome