push Distinct nodes below Sort nodes (#2717)

dolthub · Oct 24, 2024 · afe6195 · afe6195
1 parent 96a4843
commit afe6195
Show file tree

Hide file tree

Showing 8 changed files with 24,452 additions and 22,752 deletions.
diff --git a/enginetest/enginetests.go b/enginetest/enginetests.go
@@ -4773,12 +4773,11 @@ func TestTracing(t *testing.T, harness Harness) {
 	require.NoError(t, err)
 
 	spans := tracer.Spans
-	// TODO restore TopN
 	var expectedSpans = []string{
-		"plan.Limit",
+		"plan.Limit", // why Limit if there's already TopN?
+		"plan.TopN",
 		"plan.Distinct",
 		"plan.Project",
-		"plan.Sort",
 		"plan.IndexedTableAccess",
 	}
 

diff --git a/enginetest/queries/imdb_plans.go b/enginetest/queries/imdb_plans.go
diff --git a/enginetest/queries/integration_plans.go b/enginetest/queries/integration_plans.go
diff --git a/enginetest/queries/queries.go b/enginetest/queries/queries.go
@@ -10019,6 +10019,103 @@ from typestable`,
 			{uint32(1000)},
 		},
 	},
+
+	{
+		Query: `select distinct pk1 from two_pk order by pk1`,
+		Expected: []sql.Row{
+			{0},
+			{1},
+		},
+	},
+	{
+		Query: `select distinct pk2 from two_pk order by pk2`,
+		Expected: []sql.Row{
+			{0},
+			{1},
+		},
+	},
+	{
+		Query: `select distinct pk1 from two_pk order by pk2`,
+		Expected: []sql.Row{
+			{0},
+			{1},
+		},
+	},
+	{
+		Query: `select distinct pk2 from two_pk order by pk1`,
+		Expected: []sql.Row{
+			{0},
+			{1},
+		},
+	},
+	{
+		Query: `select distinct pk1, pk2 from two_pk order by pk1`,
+		Expected: []sql.Row{
+			{0, 0},
+			{0, 1},
+			{1, 0},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk1, pk2 from two_pk order by pk2`,
+		Expected: []sql.Row{
+			{0, 0},
+			{1, 0},
+			{0, 1},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk1, pk2 from two_pk order by pk1, pk2`,
+		Expected: []sql.Row{
+			{0, 0},
+			{0, 1},
+			{1, 0},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk1, pk2 from two_pk order by pk2, pk1`,
+		Expected: []sql.Row{
+			{0, 0},
+			{1, 0},
+			{0, 1},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk2, pk1 from two_pk order by pk1, pk2`,
+		Expected: []sql.Row{
+			{0, 0},
+			{1, 0},
+			{0, 1},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk2, pk1 from two_pk order by pk2, pk1`,
+		Expected: []sql.Row{
+			{0, 0},
+			{0, 1},
+			{1, 0},
+			{1, 1},
+		},
+	},
+	{
+		Query: `select distinct pk1 + 1 from two_pk order by pk1 + 1`,
+		Expected: []sql.Row{
+			{1},
+			{2},
+		},
+	},
+	{
+		Query: `select distinct pk2 + 1 from two_pk order by pk2 + 1`,
+		Expected: []sql.Row{
+			{1},
+			{2},
+		},
+	},
 }
 
 var KeylessQueries = []QueryTest{