Skip to content

Commit

Permalink
Apply IDE suggestions
Browse files Browse the repository at this point in the history
Apply suggested refactorings.
  • Loading branch information
martincostello committed May 15, 2024
1 parent 561273f commit 7f9254a
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions test/Swashbuckle.AspNetCore.Cli.Test/CommandRunnerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

namespace Swashbuckle.AspNetCore.Cli.Test
{
public class CommandRunnerTests
public static class CommandRunnerTests
{
[Fact]
public void Run_ParsesArgumentsAndExecutesCommands_AccordingToConfiguredMetadata()
public static void Run_ParsesArgumentsAndExecutesCommands_AccordingToConfiguredMetadata()
{
var receivedValues = new List<string>();
var subject = new CommandRunner("test", "a test", new StringWriter());
Expand Down Expand Up @@ -36,54 +36,54 @@ public void Run_ParsesArgumentsAndExecutesCommands_AccordingToConfiguredMetadata
});
});

var cmd1ExitCode = subject.Run(new[] { "cmd1", "--opt1", "foo", "--opt2", "bar" });
var cmd2ExitCode = subject.Run(new[] { "cmd2", "--opt1", "blah", "--opt2", "dblah" });
var cmd1ExitCode = subject.Run(["cmd1", "--opt1", "foo", "--opt2", "bar"]);
var cmd2ExitCode = subject.Run(["cmd2", "--opt1", "blah", "--opt2", "dblah"]);

Assert.Equal(2, cmd1ExitCode);
Assert.Equal(3, cmd2ExitCode);
Assert.Equal(new[] { "foo", null, "bar", "blah", null, "dblah" }, receivedValues.ToArray());
Assert.Equal(["foo", null, "bar", "blah", null, "dblah"], [.. receivedValues]);
}

[Fact]
public void Run_PrintsAvailableCommands_WhenUnexpectedCommandIsProvided()
public static void Run_PrintsAvailableCommands_WhenUnexpectedCommandIsProvided()
{
var output = new StringWriter();
var subject = new CommandRunner("test", "a test", output);
subject.SubCommand("cmd", "does something", c => {
});

var exitCode = subject.Run(new[] { "foo" });
var exitCode = subject.Run(["foo"]);

Assert.StartsWith("a test", output.ToString());
Assert.Contains("Commands:", output.ToString());
Assert.Contains("cmd: does something", output.ToString());
}

[Fact]
public void Run_PrintsAvailableCommands_WhenHelpOptionIsProvided()
public static void Run_PrintsAvailableCommands_WhenHelpOptionIsProvided()
{
var output = new StringWriter();
var subject = new CommandRunner("test", "a test", output);
subject.SubCommand("cmd", "does something", c => {
});

var exitCode = subject.Run(new[] { "--help" });
var exitCode = subject.Run(["--help"]);

Assert.StartsWith("a test", output.ToString());
Assert.Contains("Commands:", output.ToString());
Assert.Contains("cmd: does something", output.ToString());
}

[Theory]
[InlineData(new[] { "--opt1" }, new string[] { }, new[] { "cmd", "--opt2", "foo" }, true)]
[InlineData(new[] { "--opt1" }, new string[] { }, new[] { "cmd", "--opt1" }, true)]
[InlineData(new[] { "--opt1" }, new string[] { }, new[] { "cmd", "--opt1", "--opt2" }, true)]
[InlineData(new[] { "--opt1" }, new string[] { }, new[] { "cmd", "--opt1", "foo" }, false)]
[InlineData(new string[] { }, new[] { "arg1" }, new[] { "cmd" }, true)]
[InlineData(new string[] { }, new[] { "arg1" }, new[] { "cmd", "--opt1" }, true)]
[InlineData(new string[] {}, new[] { "arg1" }, new[] { "cmd", "foo", "bar" }, true)]
[InlineData(new string[] {}, new[] { "arg1" }, new[] { "cmd", "foo" }, false)]
public void Run_PrintsCommandUsage_WhenUnexpectedArgumentsAreProvided(
[InlineData(new[] { "--opt1" }, new string[0], new[] { "cmd", "--opt2", "foo" }, true)]
[InlineData(new[] { "--opt1" }, new string[0], new[] { "cmd", "--opt1" }, true)]
[InlineData(new[] { "--opt1" }, new string[0], new[] { "cmd", "--opt1", "--opt2" }, true)]
[InlineData(new[] { "--opt1" }, new string[0], new[] { "cmd", "--opt1", "foo" }, false)]
[InlineData(new string[0], new[] { "arg1" }, new[] { "cmd" }, true)]
[InlineData(new string[0], new[] { "arg1" }, new[] { "cmd", "--opt1" }, true)]
[InlineData(new string[0], new[] { "arg1" }, new[] { "cmd", "foo", "bar" }, true)]
[InlineData(new string[0], new[] { "arg1" }, new[] { "cmd", "foo" }, false)]
public static void Run_PrintsCommandUsage_WhenUnexpectedArgumentsAreProvided(
string[] optionNames,
string[] argNames,
string[] providedArgs,
Expand All @@ -107,4 +107,4 @@ public void Run_PrintsCommandUsage_WhenUnexpectedArgumentsAreProvided(
Assert.Empty(output.ToString());
}
}
}
}

0 comments on commit 7f9254a

Please sign in to comment.