Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move notebooks to sub-directory #139

Open
dominikmn opened this issue Aug 27, 2021 · 0 comments
Open

Move notebooks to sub-directory #139

dominikmn opened this issue Aug 27, 2021 · 0 comments
Assignees
@dominikmn

Comments

@dominikmn
Copy link
Owner

dominikmn commented Aug 27, 2021 •
edited
Loading

(duplicate of #18)
Move the notebooks to a separate subfolder ./notebooks/
This includes the following tasks

  • Add setup.py
  • Adapt scripts in ./utils/
  • Adapt the paths in the notebook files
  • Adapt README.md
@dominikmn dominikmn self-assigned this Aug 27, 2021
dominikmn added a commit that referenced this issue Sep 4, 2021
@dominikmn
Issue #139: WIP: Move notebooks to subfolder
e18406a 
Moving the notebooks to the subfolder `./notebooks/`.
This commit does not yet include the other necessary changes which this
movement requires (create setup.py, adapt utils-scripts, adapt
README.md, ...)
dominikmn added a commit that referenced this issue Sep 5, 2021
@dominikmn
Issue #139: WIP: Move notebooks to subfolder
e344711 
Follow up of commit e18406a.
* Introducing setup.py
* Including `-e .` in requirements.txt
* Adapting the relative paths in the notebook files
* Adapting relative paths and including usage of pathlib in
  - `utils/nlp.py`
  - `utils/modeling.py`
  - `utils/loading.py`
* Testing and re-running all the notebook files
* Fixing missing import in `translation_validation.py`
* Adapting README.md
@dominikmn dominikmn mentioned this issue Sep 7, 2021
Open
@dominikmn dominikmn changed the title Move notebooks to subfolder Move notebooks to sub-directory Sep 7, 2021
@dominikmn dominikmn mentioned this issue Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikmn dominikmn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dominikmn