bgpd: Simplify for loop

This for loop has no chance of removing entries so there is no need to do a bit of complicated code to handle the case where an entry can be removed. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp · Mar 3, 2024 · 0a8dfbe · 0a8dfbe
1 parent f9c8673
commit 0a8dfbe
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
@@ -2907,9 +2907,7 @@ void bgp_best_selection(struct bgp *bgp, struct bgp_dest *dest,
 	}
 
 	if (do_mpath && new_select) {
-		for (pi = bgp_dest_get_bgp_path_info(dest);
-		     (pi != NULL) && (nextpi = pi->next, 1); pi = nextpi) {
-
+		for (pi = bgp_dest_get_bgp_path_info(dest); pi; pi = pi->next) {
 			if (debug)
 				bgp_path_info_path_with_addpath_rx_str(
 					pi, path_buf, sizeof(path_buf));