bgpd: Cleanup indenting for subgroup_default_originate

Part of the subgroup_default_originate function was indented very deeply. Clean this up some. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp · Mar 4, 2024 · c0cdeda · c0cdeda
1 parent 317f5b6
commit c0cdeda
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/bgpd/bgp_updgrp_adv.c b/bgpd/bgp_updgrp_adv.c
@@ -993,22 +993,23 @@ void subgroup_default_originate(struct update_subgroup *subgrp, bool withdraw)
 		if (dest) {
 			for (pi = bgp_dest_get_bgp_path_info(dest); pi;
 			     pi = pi->next) {
-				if (CHECK_FLAG(pi->flags, BGP_PATH_SELECTED)) {
-					if (subgroup_announce_check(
-						    dest, pi, subgrp,
-						    bgp_dest_get_prefix(dest),
-						    &attr, NULL)) {
-						struct attr *default_attr =
-							bgp_attr_intern(&attr);
-
-						if (!bgp_adj_out_set_subgroup(
-							    dest, subgrp,
-							    default_attr, pi))
-							bgp_attr_flush(
-								&default_attr);
-					} else
-						bgp_attr_flush(&attr);
-				}
+				if (!CHECK_FLAG(pi->flags, BGP_PATH_SELECTED))
+					continue;
+
+				if (subgroup_announce_check(dest, pi, subgrp,
+							    bgp_dest_get_prefix(
+								    dest),
+							    &attr, NULL)) {
+					struct attr *default_attr =
+						bgp_attr_intern(&attr);
+
+					if (!bgp_adj_out_set_subgroup(dest,
+								      subgrp,
+								      default_attr,
+								      pi))
+						bgp_attr_flush(&default_attr);
+				} else
+					bgp_attr_flush(&attr);
 			}
 			bgp_dest_unlock_node(dest);
 		}