From dd1e34eff498985d8af26cfc329e751a4b022a9b Mon Sep 17 00:00:00 2001 From: Sai Gomathi N Date: Wed, 30 Aug 2023 05:45:18 -0700 Subject: [PATCH] pimd,pim6d: Resolving the YANG datatype Inconsistency for PIM Hello Interval The YANG specification currently designates a uint8 data type for the hello interval, despite the CLI documentation (ip pim hello (1-65535) [(1-65535)]) indicating a maximum value of 65535. To address this inconsistency, updating the data type to uint16 allowing for a maximum value for hello intervals. Signed-off-by: Sai Gomathi N --- pimd/pim_nb_config.c | 2 +- yang/frr-pim.yang | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pimd/pim_nb_config.c b/pimd/pim_nb_config.c index 30d84710e667..be05b69401e4 100644 --- a/pimd/pim_nb_config.c +++ b/pimd/pim_nb_config.c @@ -1633,7 +1633,7 @@ int lib_interface_pim_address_family_hello_interval_modify( ifp = nb_running_get_entry(args->dnode, NULL, true); pim_ifp = ifp->info; pim_ifp->pim_hello_period = - yang_dnode_get_uint8(args->dnode, NULL); + yang_dnode_get_uint16(args->dnode, NULL); pim_ifp->pim_default_holdtime = -1; break; } diff --git a/yang/frr-pim.yang b/yang/frr-pim.yang index 105dab895da5..e9b3f675073d 100644 --- a/yang/frr-pim.yang +++ b/yang/frr-pim.yang @@ -343,7 +343,7 @@ module frr-pim { } leaf hello-interval { - type uint8 { + type uint16 { range "1..max"; } default "30";