New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal Error: Concurrent Map Writes #75

Open

jirevwe opened this issue Mar 22, 2024 · 0 comments

jirevwe commented Mar 22, 2024

When registering a module concurrently, it panics.

github.com/dop251/goja_nodejs/require.RegisterCoreModule(...)

goja_nodejs/require/module.go

Lines 240 to 246 in 27eeffc

    
           func RegisterCoreModule(name string, loader ModuleLoader) { 
        
           	if builtin == nil { 
        
           		builtin = make(map[string]ModuleLoader) 
        
           	} 
        
           	name = filepathClean(name) 
        
           	builtin[name] = loader 
        
           }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment