Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarQube timeout property #29886

Closed
spbolton opened this issue Sep 5, 2024 · 0 comments · Fixed by #29887
Closed

Fix SonarQube timeout property #29886

spbolton opened this issue Sep 5, 2024 · 0 comments · Fixed by #29887

Comments

@spbolton
Copy link
Contributor

spbolton commented Sep 5, 2024

SonarQube background processing runs seem to sometimes take over 5 minutes at the moment. In the CICD workflows we submit the report from the build and then polls until SonarQube acknowledges that the processing is complete, there is a timeout setting here we had set at 10 minutes already,it turns out that the timeout-minutes property was being ignored and sonarqube updated the action last week in their master branch to add a pollingTimeoutSec option that defauts to 300s (5 min) We have therefore started to fail on master scans that take over this time. We need to update to add the pollingTimeoutSec property and this is an example of what happens if plugins are not version locked to ensure it is repeatable.

SonarSource/sonarqube-quality-gate-action#50

Timings of our reports are here
https://sonarqube.dotcms.site/admin/background_tasks?taskType=REPORT

@spbolton spbolton converted this from a draft issue Sep 5, 2024
@spbolton spbolton self-assigned this Sep 5, 2024
@spbolton spbolton changed the title Increase SonarQube timeout to 10 min Fix SonarQube timeout property Sep 5, 2024
@spbolton spbolton linked a pull request Sep 5, 2024 that will close this issue
3 tasks
@spbolton spbolton moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Sep 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2024
### Proposed Changes
* Fix the action to the current commit
https://github.com/sonarsource/sonarqube-quality-gate-action/tree/dc2f7b0dd95544cd550de3028f89193576e958b9
for reproducability instead of auto updting any change to master branch.
Includes the timeout change in this PR
SonarSource/sonarqube-quality-gate-action#50
*
* set the new pollingTimeoutSec to 600 (e.g. 10 minutes)

To test, check the logs of the build run in the sonarqube step and it
should show the timeout passed in as "600" instead of "300"

### Checklist
- [ ] Tests
- [ ] Translations
- [ ] Security Implications Contemplated (add notes if applicable)

### Additional Info
This PR resolves #29886 (Fix SonarQube timeout property).


### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
** original screenshot **  |  ** updated screenshot **
@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Sep 5, 2024
@nollymar nollymar moved this from Internal QA to Done in dotCMS - Product Planning Sep 5, 2024
dsolistorres pushed a commit that referenced this issue Sep 18, 2024
### Proposed Changes
* Fix the action to the current commit
https://github.com/sonarsource/sonarqube-quality-gate-action/tree/dc2f7b0dd95544cd550de3028f89193576e958b9
for reproducability instead of auto updting any change to master branch.
Includes the timeout change in this PR
SonarSource/sonarqube-quality-gate-action#50
*
* set the new pollingTimeoutSec to 600 (e.g. 10 minutes)

To test, check the logs of the build run in the sonarqube step and it
should show the timeout passed in as "600" instead of "300"

### Checklist
- [ ] Tests
- [ ] Translations
- [ ] Security Implications Contemplated (add notes if applicable)

### Additional Info
This PR resolves #29886 (Fix SonarQube timeout property).


### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
** original screenshot **  |  ** updated screenshot **
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants