From a8f58fc3d504311b62f86b413b1c3be661a51443 Mon Sep 17 00:00:00 2001
From: EnderDev <kieran@dothq.org>
Date: Sat, 16 Dec 2023 15:30:11 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Add=20support=20for=20select=20opti?=
 =?UTF-8?q?on=20preference=20handles?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../dev/content/dev-preferences-popout.js     | 56 ++++++++++++++++---
 1 file changed, 47 insertions(+), 9 deletions(-)

diff --git a/components/dev/content/dev-preferences-popout.js b/components/dev/content/dev-preferences-popout.js
index 4440681dd9..bcb903b213 100644
--- a/components/dev/content/dev-preferences-popout.js
+++ b/components/dev/content/dev-preferences-popout.js
@@ -44,9 +44,10 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 		}
 	}
 
-	getInputTypeForType(type) {
+	getInputTypeForType(type, value) {
 		switch (type) {
 			case "string":
+				if (Array.isArray(value)) return "select";
 				return "text";
 			case "boolean":
 				return "checkbox";
@@ -59,11 +60,11 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 		let attributes = {
 			value: null,
 			type: null,
-			inputType: null,
+			inputType: this.handles.get(prefId)?.inputType,
 			locked: Services.prefs.prefIsLocked(prefId)
 		};
 
-		const { PREF_BOOL, PREF_INT } = Ci.nsIPrefBranch;
+		const { PREF_BOOL, PREF_INT, PREF_STRING } = Ci.nsIPrefBranch;
 
 		const prefTypeInt = Services.prefs.getPrefType(prefId);
 
@@ -79,8 +80,10 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 		}
 
 		if (!attributes.type) {
-			if (typeof defaultValue !== "undefined") {
-				attributes.type = typeof defaultValue;
+			if (defaultValue !== null) {
+				attributes.type = Array.isArray(defaultValue)
+					? "string"
+					: typeof defaultValue;
 				attributes.value = defaultValue;
 			} else {
 				try {
@@ -90,13 +93,17 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 			}
 		}
 
-		attributes.inputType = this.getInputTypeForType(attributes.type);
+		attributes.inputType = this.getInputTypeForType(
+			attributes.type,
+			attributes.value
+		);
 
 		return attributes;
 	}
 
 	getPrefValue(prefId) {
-		return this.getPrefAttributes(prefId).value;
+		const value = this.getPrefAttributes(prefId).value;
+		return value;
 	}
 
 	registerHandle(prefId, defaultValue = null) {
@@ -130,9 +137,18 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 		}
 
 		const handleInputEl = /** @type {HTMLInputElement} */ (
-			html("input", handleInputAttrs)
+			html(
+				prefAttributes.inputType == "select" ? "select" : "input",
+				handleInputAttrs
+			)
 		);
 
+		if (prefAttributes.inputType == "select") {
+			for (const opt of prefAttributes.value) {
+				handleInputEl.appendChild(html("option", { value: opt }, opt));
+			}
+		}
+
 		handleInputEl.addEventListener("change", (e) => {
 			switch (prefAttributes.type) {
 				case "string":
@@ -160,7 +176,7 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 			defaultValue
 		});
 
-		this.setHandleValue(prefId, prefAttributes.value);
+		this.setHandleValue(prefId, this.getPrefValue(prefId));
 
 		handleEl.appendChild(handleInputEl);
 
@@ -233,6 +249,27 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 			}
 		});
 
+		const LOG_LEVELS = [
+			"all",
+			"debug",
+			"log",
+			"info",
+			"clear",
+			"trace",
+			"timeEnd",
+			"time",
+			"assert",
+			"group",
+			"groupEnd",
+			"profile",
+			"profileEnd",
+			"dir",
+			"dirxml",
+			"warn",
+			"error",
+			"off"
+		];
+
 		// Preference handles:
 		this.registerHandle("dot.window.use-native-titlebar", false);
 		this.registerHandle("dot.tabs.debug_information.visible", false);
@@ -241,6 +278,7 @@ class DevelopmentPreferencesPopout extends MozHTMLElement {
 		this.registerHandle("dot.panels.debug_information.visible", false);
 		this.registerHandle("dot.tabs.in_animation_duration_ms", 50);
 		this.registerHandle("dot.tabs.out_animation_duration_ms", 30);
+		this.registerHandle("dot.customizable.loglevel", LOG_LEVELS);
 
 		Services.prefs.addObserver("", this.observePreferences.bind(this));
 	}