Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation config does not reflect navigation menu #299

Open
pinclau opened this issue Oct 16, 2024 · 5 comments
Open

Navigation config does not reflect navigation menu #299

pinclau opened this issue Oct 16, 2024 · 5 comments
Assignees
Milestone

Comments

@pinclau
Copy link
Member

pinclau commented Oct 16, 2024

Changing something in navigation.global.php does not reflect in the admin left menu from admin, it seems that is not used at all

@alexmerlin
Copy link
Member

It's because when the new theme was implemented, the navigation was hardcoded instead of reusing the existing implementation.
https://github.com/dotkernel/admin/blob/5.0/src/App/templates/partial/left-menu.html.twig

@pinclau
Copy link
Member Author

pinclau commented Oct 16, 2024

Yes, i saw that but i was tinking about fix it or delete it, why require dot-navigation and keep those config file if they are not used.

@alexmerlin
Copy link
Member

Good question... but, I'm not the author of the new theme implementation.

I agree that we should either:

  • reimplement dot-navigation (recommended)
  • remove both dot-navigation and its config file, to avoid further confusions

@arhimede
Copy link
Member

Reimplement dot-navigation seem a good direction

@bidi47 maybe ?

@arhimede
Copy link
Member

or maybe @MarioRadu ?

@arhimede arhimede pinned this issue Oct 17, 2024
@arhimede arhimede added this to Backlog Oct 17, 2024
@arhimede arhimede moved this to Todo in Backlog Nov 21, 2024
@arhimede arhimede added this to the 5.2.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

4 participants