Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused code inherited from version 4.0 #73

Merged
merged 7 commits into from
Dec 6, 2024
Merged

removed unused code inherited from version 4.0 #73

merged 7 commits into from
Dec 6, 2024

Conversation

SergiuBota1
Copy link
Member

Removed unused code inherited from version 4.0
close #70

Removing unused code also fixed phpcs erros for mail.global.php.dist
close #72

@SergiuBota1 SergiuBota1 added the 5.0 label Dec 4, 2024
@SergiuBota1
fixed phpcs error
02f0a76 
Signed-off-by: sergiu <[email protected]>
@SergiuBota1
removed unused line
062b763 
Signed-off-by: sergiu <[email protected]>
@SergiuBota1 SergiuBota1 removed the request for review from Jurj-Bogdan December 4, 2024 14:23
arhimede
arhimede reviewed Dec 4, 2024
View reviewed changes
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
@alexmerlin
Copy link
Member

Just to confirm, according to the mailer CHANGELOG:

  • auth_mode has been removed in version 4.4.0 - this was the equivalent of our connection_class config (as mentioned in the old mailer docs)

@alexmerlin
Copy link
Member

FYI, besides regular SmtpTransport there is also EsmtpTransport, which seems to add many enhancements to the SMTP protocol. Comparison here: https://www.geeksforgeeks.org/what-is-esmtp-extended-simple-mail-transfer-protocol/

alexmerlin
alexmerlin requested changes Dec 5, 2024
View reviewed changes
config/mail.global.php Outdated Show resolved Hide resolved
docs/book/v5/configuration.md Outdated Show resolved Hide resolved
docs/book/v5/transports.md Outdated Show resolved Hide resolved
docs/book/v5/transports.md Outdated Show resolved Hide resolved
test/CommonTrait.php Outdated Show resolved Hide resolved
alexmerlin
alexmerlin requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final tweaks... 🤞

config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
config/mail.global.php.dist Outdated Show resolved Hide resolved
@alexmerlin
Copy link
Member

@arhimede Also note that since version 6.2, symfony/mailer has a command for sending test emails that might come handy when testing mail configurations.

@SergiuBota1
config corrections
7967109 
Signed-off-by: sergiu <[email protected]>
@arhimede arhimede merged commit 5733ca1 into 5.0 Dec 6, 2024
27 of 28 checks passed
@arhimede arhimede deleted the issues-70 branch December 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimede arhimede arhimede approved these changes

@alexmerlin alexmerlin alexmerlin approved these changes

@MarioRadu MarioRadu Awaiting requested review from MarioRadu

Assignees
No one assigned
Labels
5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run phpcs on mail.global.php.dist connection_class ?
3 participants
@SergiuBota1 @alexmerlin @arhimede