Skip to content

Commit

Permalink
refactor: remove karstat
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrefkl committed Dec 30, 2024
1 parent 20d3db9 commit 48cafef
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 237 deletions.
187 changes: 0 additions & 187 deletions clients/karstat.py

This file was deleted.

17 changes: 0 additions & 17 deletions grades_api_v2/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,23 +198,6 @@ class Meta:
)


class KarstatGradeReportSerializer(serializers.Serializer):
username = serializers.CharField()
password = serializers.CharField()
department = serializers.PrimaryKeyRelatedField(queryset=Department.objects.all())
year = serializers.IntegerField()
semester = serializers.ChoiceField(choices=Semester.choices)

class Meta:
fields = (
"username",
"password",
"department",
"year",
"semester",
)


class NSDGradeReportSerializer(serializers.Serializer):
course = serializers.SlugRelatedField(
queryset=Course.objects.all(),
Expand Down
3 changes: 0 additions & 3 deletions grades_api_v2/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@
TIAScraperRouter = router.register(
"scrapers/tia", views.TIAScraperViewSet, basename="scrapers-tia"
)
KarstatScraperRouter = router.register(
"scrapers/karstat", views.KarstatScraperViewSet, basename="scrapers-karstat"
)
NSDScraperRouter = router.register(
"scrapers/nsd", views.NSDScraperViewSet, basename="scrapers-nsd"
)
Expand Down
28 changes: 0 additions & 28 deletions grades_api_v2/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
from rest_framework.settings import api_settings
from rest_framework_extensions.mixins import NestedViewSetMixin

from clients.course_pages import CoursePagesClient
from clients.karstat import KarstatGradeClient
from clients.nsd import NSDGradeClient
from clients.tia import TIACourseClient, TIADepartmentClient, TIAFacultyClient
from services.course_service import CourseService
from services.grade_service import GradeService
Expand Down Expand Up @@ -44,7 +41,6 @@
DepartmentSerializer,
UserSerializer,
TIAObjectListRefreshSerializer,
KarstatGradeReportSerializer,
NSDGradeReportSerializer,
NSDFullGradeReportSerializer,
)
Expand Down Expand Up @@ -243,30 +239,6 @@ def refresh_departments(self, request, *args, **kwargs):
)


class KarstatScraperViewSet(viewsets.GenericViewSet):
@action(
url_path="grade-report",
detail=False,
methods=["POST"],
serializer_class=KarstatGradeReportSerializer,
permission_classes=(permissions.IsAdminUser,),
)
def grade_report(self, request, *args, **kwargs):
serializer = self.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
data = serializer.data
department = Department.objects.get(pk=data.get("department"))
client = KarstatGradeClient()
client.login(
username=data.get("username"), password=data.get("password"),
)
grades = client.update_grade_stats(
department=department, year=data.get("year"), semester=data.get("semester"),
)
grades_serializer = GradeSerializer(instance=grades, many=True)
return Response(status=status.HTTP_200_OK, data=grades_serializer.data)


class NSDScraperViewSet(viewsets.GenericViewSet):
@action(
url_path="grade-report",
Expand Down
4 changes: 2 additions & 2 deletions templates/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ <h1>Teknisk info</h1>
<div class="row">
<div class="col-md-8">
<h1>Informasjon</h1>
<a target="_blank" href="http://www.ntnu.no/karstat/login.do"><h3>Karakterstatistikk</h3></a>
<a target="_blank" href="https://dbh.hkdir.no/"><h3>Karakterstatistikk</h3></a>
<p>Inneholder karakterstatistikk for alle fakultetene på NTNU.</p>
<a target="_blank" href="http://www.ime.ntnu.no/api"><h3>Faginformasjon</h3></a>
<p>API som tilbyr innformasjon om fagene som går på NTNU.</p>
<p>API som tilbyr informasjon om fagene som går på NTNU.</p>
</div>
</div>

Expand Down

0 comments on commit 48cafef

Please sign in to comment.