refactor: simplify ternary

dotkom · Sep 13, 2024 · b582de3 · b582de3
1 parent b51e53a
commit b582de3
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/profile/components/Settings/Penalties/Rules.tsx b/src/profile/components/Settings/Penalties/Rules.tsx
@@ -15,11 +15,13 @@ interface IProps {
 const inFuture = (date: string) => new Date(date) > new Date();
 
 const getLatestRuleSet = (rules: IMarkRule[]): IMarkRule => {
-  return rules.reduce(
-    (latest, rule) =>
-      !inFuture(rule.valid_from_date) && rule.valid_from_date > latest.valid_from_date ? rule : latest,
-    rules[0]
-  );
+  return rules.reduce((latest, rule) => {
+    if (inFuture(rule.valid_from_date)) {
+      return latest;
+    }
+
+    return rule.valid_from_date > latest.valid_from_date ? rule : latest;
+  }, rules[0]);
 };
 
 export const Info = ({ rules }: IProps) => {