-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split MapStaticAssets and UseStaticFiles into 2 docs #34080
Comments
The UID/file naming doesn't match the usual convention for lowercase, possibly with dashes. Should it be more like ...
|
I vote for map-static-files and use-static-files UID and file name. Whatever we do, I don't think we want upper case letters in UID or file name. |
Comments on the procedural text here for splitting the article into two:
|
Blazor article text that applies to all ASP.NET Core static file scenarios should move. Much of what's in the Blazor article is specific to Blazor, and it shouldn't be moved into the main doc set articles. I floated the idea that Blazor fundamentals content (all of it, not just for static files) should be moved entirely to the main doc set Fundamentals node (somehow), but no 🎲🎲 on that suggestion. I suppose it would be efficient if I made a set of HTML comments in that text for what can be moved and what has to stay. I've opened #34098, and I'll try to get that done today but certainly by EOW at the latest. |
For sure I'm not going to change the original UID which is a PK, no reason. There's no advantage to following a semi-convention on the implementation of the PK. I'll follow the convention for mapstaticfiles, UID:
@guardrex will handle the Blazor changes
No, it makes it easier, all that goes to the usestaticfiles file with a pointer to that in the mapstaticfiles files. mapstaticfiles handles the majority use case. If you need something that can only be done with usestaticfiles, that's in another doc.
I'll let @guardrex refactor the Blazor-specific content |
I'll cut out 🔪 the offending bits from the Blazor article, but I'll wait until the split takes place here and new Map Static Files article goes into place. That way, I can cross-link to it. It's also probably best for me to wait so that you can see what I have there. I understand you're going to two articles, while the single Blazor article has them both, but you can at least lift any of the text that you like before I get to cutting 🔪🔪 🔪 🔪 on the article. |
Description
Per #34002, split them via:
UseStaticFiles
from this doc. setuid: fundamentals/mapStaticFiles
Probably rename the file MapStaticAssets.md ( unless it messes up the PR files diff)The above will make for the most productive changes to review.
After PR merges, hook up the TOC for mapStaticFiles
Review
UseStaticFiles
history to see whatUseStaticFiles
changes were made from .NET 8 to .NET 9. I think only a few bug fixes.@tdykstra @guardrex please review.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/fundamentals/static-files?view=aspnetcore-9.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/fundamentals/static-files.md
Document ID
3fec6e08-fc99-7a5c-796f-3f2347cad891
Article author
@Rick-Anderson
Related Issues
Associated WorkItem - 343087
The text was updated successfully, but these errors were encountered: