Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionScope async limitations #4306

Closed
ProTip opened this issue Mar 30, 2023 · 1 comment · Fixed by #4307
Closed

TransactionScope async limitations #4306

ProTip opened this issue Mar 30, 2023 · 1 comment · Fixed by #4307
Assignees
Milestone

Comments

@ProTip
Copy link

ProTip commented Mar 30, 2023

It may be worth discussing in limitations the apparent footgun with transaction scopes in that they do not support asynchronously committing or rolling back transactions.

In asp.net "async everything" is highly encouraged so the absence of await using or await scope.CompleteAsync() sent me down an internet rabbit hole trying to figure out if committing was blocking(yes of course).

This issue on dotnet seems to be requesting the API be extended for async complete/dispose: dotnet/runtime#1420 .


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

roji added a commit to roji/EntityFramework.Docs that referenced this issue Mar 31, 2023
@roji
Copy link
Member

roji commented Mar 31, 2023

I've submitted #4307 to add a note on this.

@roji roji self-assigned this Mar 31, 2023
@roji roji added this to the 8.0.0 milestone Mar 31, 2023
roji added a commit to roji/EntityFramework.Docs that referenced this issue Mar 31, 2023
@roji roji closed this as completed in #4307 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants