Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how function pointers will handle context registers #309

Merged

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Dec 21, 2023

Description

This PR adds more information on how function pointers will handle context registers.

proposed/swift-interop.md Outdated Show resolved Hide resolved
proposed/swift-interop.md Outdated Show resolved Hide resolved
@kotlarmilos kotlarmilos changed the title Specify how delegates will handle context registers Specify how function pointers will handle context registers Dec 21, 2023
proposed/swift-interop.md Outdated Show resolved Hide resolved
@jkotas
Copy link
Member

jkotas commented Dec 21, 2023

The proposal mentions CallConvSwift in a few places, but it does not say what it is.

Would it make sense to explicitly mention CallConvSwift at the end of the initial paragraph on calling convention and say that it can be used in all positions where other existing calling convention modifiers can be used, that means: UnmanagedCallConvAttribute for P/Invoke, UnmanagedCallersOnlyAttribute.CallConv for reverse P/Invoke and unmanaged function pointers (delegate* unmanaged[Swift]`).

proposed/swift-interop.md Outdated Show resolved Hide resolved
proposed/swift-interop.md Outdated Show resolved Hide resolved
proposed/swift-interop.md Outdated Show resolved Hide resolved
kotlarmilos and others added 2 commits January 3, 2024 09:31
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

We should make sure @jkoritzinsky signs off on this from the CoreCLR side too.

@kotlarmilos kotlarmilos merged commit 814bb1c into dotnet:main Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants