Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle part of Swift frozen struct ABI in the projection layers #310

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

jkoritzinsky
Copy link
Member

Due to high cost of implementation in RyuJIT, update the Swift frozen type handling design to require the first lowering pass to be done at the projection layer so the signatures the JIT sees are already broken down to primitive type sequences if necessary.

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This proposal will greatly simplify things on our side.

proposed/swift-interop.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
@JulieLeeMSFT
Copy link
Member

Thanks for the design that simplifies the JIT work!

@jkoritzinsky jkoritzinsky merged commit 6a42f0e into dotnet:main Jan 8, 2024
2 checks passed
@jkoritzinsky jkoritzinsky deleted the frozen-struct-handling branch January 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants