Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - WarningAsError doesn't work for 3261 #18016

Closed
1 of 7 tasks
Lanayx opened this issue Nov 17, 2024 · 3 comments
Closed
1 of 7 tasks

Nullness issue - WarningAsError doesn't work for 3261 #18016

Lanayx opened this issue Nov 17, 2024 · 3 comments
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Triage-Investigate
Milestone

Comments

@Lanayx
Copy link
Contributor

Lanayx commented Nov 17, 2024

Issue description

WarningAsError doesn't have effect in certain cases

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

.NET SDK 9.0.100

Reproducible code snippet and actual behavior

  1. Clone Oxpecker repository, observe this line, nulness warnings are set as errors
  2. Go to this line, change (rawRangeHeader[0] |> string) to just rawRangeHeader[0]
  3. Build the project
  4. Observer the warning that is not an error

Possible workarounds

Ignore problem

@Lanayx Lanayx added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Nov 17, 2024
@github-actions github-actions bot added this to the Backlog milestone Nov 17, 2024
@T-Gro T-Gro removed their assignment Nov 18, 2024
@abonie abonie modified the milestones: Backlog, November-2024 Nov 25, 2024
@abonie
Copy link
Member

abonie commented Nov 25, 2024

Hi @Lanayx , is it possible for you to provide a minimal repro (for our convenience)?

@Lanayx
Copy link
Contributor Author

Lanayx commented Nov 25, 2024

@abonie it looks like this code is sufficient

let test (s: string | null): string =
    s

@Lanayx
Copy link
Contributor Author

Lanayx commented Nov 25, 2024

Oops, as I checked, it appeared that WarningsAsErrors was defined twice and the second one overrode the correct one, sorry for that and thanks for checking

@Lanayx Lanayx closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Triage-Investigate
Projects
Archived in project
Development

No branches or pull requests

3 participants