Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix CarouselViewRemoveAt so that it's passing on both CV1 and CV2 sets of handlers #25776

Closed
PureWeen opened this issue Nov 11, 2024 · 2 comments · Fixed by #25919
Closed
Assignees
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView partner/syncfusion Issues / PR's with Syncfusion collaboration platform/iOS 🍎 s/triaged Issue has been reviewed
Milestone

Comments

@PureWeen
Copy link
Member

Description

This test was modified to only run on CV2 because it's not passing on CV1
https://github.com/dotnet/maui/pull/25719/files

We need to fix it so the test is passing on both sets of handlers

@PureWeen PureWeen added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/iOS 🍎 labels Nov 11, 2024
@PureWeen PureWeen added this to the .NET 9 Servicing milestone Nov 11, 2024
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@NirmalKumarYuvaraj
Copy link
Contributor

NirmalKumarYuvaraj commented Nov 15, 2024

Issue details

When using CV1 handlers, removing the first item from the CarouselView during navigation doesn't work as expected. The removed item remains visible in the view . This functionality works correctly with CV2 handlers.

Steps to Reproduce

  1. Go to this file CarouselViewRemoveAt and Replace CarouselView2 with CarouselView1.
  2. Run this test case.
  3. Notice the first slide with text as 1 is still in the view.

Output

Expected Actual
Handler2.mov
Handler1.mov

@rmarinho rmarinho modified the milestones: .NET 9 Servicing, .NET 9 SR3 Dec 9, 2024
@rmarinho rmarinho moved this from Todo to In Progress in MAUI SDK Ongoing Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Dec 11, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView partner/syncfusion Issues / PR's with Syncfusion collaboration platform/iOS 🍎 s/triaged Issue has been reviewed
Projects
Status: Done
5 participants