-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout in System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers #101193
Comments
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
See the discussion in #59678 for context |
This was written to try to catch
as explicitly as possible but there are a lot of other forms of timeouts for wasm |
@BrzVlad the particular failure this issue seems to catch looks like it is specfic to the desktop interpreter, can you take a look? |
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
I did a few runs locally and I'm not seeing anything suspicious. It just looks like a heavy suite that takes a long time to run. Also I'm seeing that all these failures are on debug builds. While for jit/aot, debug build doesn't have a big impact, the interpreter execution engine is written in C and it can easily get 3x slower in debug build. I'm not sure if it easy to do, but I think this test suite should be disabled on interpreter debug builds |
Disabled suite in debug runtime builds in /github.com//pull/101483 |
reopening since a few builds weren't against the tip of main and hit this, feel free to close again next week |
removing blocking-clean-ci as it has not failed in 30 days
|
Fixed by #101556 |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=646861
Build error leg or test failing: System.Text.Json.Tests.WorkItemExecution
Pull request: #101140
Error Message
Fill the error message using step by step known issues guidance.
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=646861
Error message validated:
[Takes very long to run on interpreter. System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers ['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/17/2024 5:06:43 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: