-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead lettering tests #101524
Comments
Tagging subscribers to 'arch-wasm': @lewing |
In the same PR's build where the above dead-letter failure was found, there's another run for a similar queue but is
^ It just dies after printing the second line. I do not want to open a KnownBuildError issue for this specific failure as it would end up grouping anything. I am concerned that people are going to get blocked on getting their PRs merged because they cannot bypass the merge on green restriction. For example, this PR is already blocked and I will only be able to merge it if I JIT elevate myself: #101498 |
People should be able to use https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/failure-analysis.md#bypassing-build-analysis . Have you tried that before JIT elevating? |
I was not aware of that. Thanks for sharing! I'll try it next time. |
What does dead-lettering mean in this context? What is the case where this fails? |
iirc Dead Lettering is usually infrastructure related, is that correct @steveisok ? We often see queues fall over around branch time
|
Correct. @ilyas1974 is queue dead lettering manually driven or is there some automation involved? |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
For you dead lettering question, the answer is Yes - it's a manual and automated process. We manually deadletter a queue so the changes are immediate. We then add the deadletter information to the helix configuration, so he is persistent for whenever we make changes to helix. |
Ok, so is the expectation that tests should be re-run when deadlettering happens? That basically, that run was invalid? |
I've removed the wasm references in the labels and title bits because wasm is no longer dominating the failures in any way (with the exception of preview4 which has known problems that are fixed in main) |
Bypassing these tests doesn't seem appropriate. I'm closing the issue. |
Build Information
Build: https://dev.azure.com/dnceng-public/public/public%20Team/_build/results?buildId=654910
Build error leg or test failing:
browser-wasm windows Release LibraryTests_Smoke_AOT
Error Message
net9.0-browser-Release-wasm-Mono_Release-WasmTestOnV8
Report
Summary
The text was updated successfully, but these errors were encountered: