Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.HostFactoryResolver project is not building #103553

Closed
kasperk81 opened this issue Jun 17, 2024 · 3 comments · Fixed by #103609
Closed

Microsoft.Extensions.HostFactoryResolver project is not building #103553

kasperk81 opened this issue Jun 17, 2024 · 3 comments · Fixed by #103609
Assignees
Milestone

Comments

@kasperk81
Copy link
Contributor

Microsoft.Extensions.HostFactoryResolver project is located in runtime but excluded from runtime build. it is built as part of efcore and aspnetcore. if there was a problem with the code being merged it goes undetected (#102152) and blocks the code flow (#103523, #103546).

@ViktorHofer @ericstj

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 17, 2024
@buyaa-n buyaa-n added area-Extensions-Hosting and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 17, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

@ericstj
Copy link
Member

ericstj commented Jun 17, 2024

It's a source package, the source is built by the tests:

Perhaps the problem here is that the test is disabling some warnings that EFCore and ASPNETCore care about? Maybe you could suggest what changes to make to the test that would match how EFCore and ASPNETCore consume it? We're not so much a fan of this package living in runtime - it's only here because it's a place for EFCore and ASPNETCore to share code. cc @halter73

@kasperk81
Copy link
Contributor Author

<Nullable>enable</Nullable> at least that one.

@ericstj ericstj self-assigned this Jun 17, 2024
@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2024
@ericstj ericstj added this to the 9.0.0 milestone Jun 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants