Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting assert in NibbleMapDeleteUnlocked #109970

Closed
kunalspathak opened this issue Nov 19, 2024 · 4 comments · Fixed by #109976
Closed

Hitting assert in NibbleMapDeleteUnlocked #109970

kunalspathak opened this issue Nov 19, 2024 · 4 comments · Fixed by #109976
Assignees
Labels
area-VM-coreclr in-pr There is an active PR which will close this issue when it is merged

Comments

@kunalspathak
Copy link
Member

Introduced in #108939


Assert failure(PID 21700 [0x000054c4], Thread: 47520 [0xb9a0]): ((*pMap) & ~mask) && !IsPointer(*pMap)

CORECLR! EEJitManager::NibbleMapDeleteUnlocked + 0x158 (0x00007ff9`161db138)
CORECLR! EEJitManager::RemoveJitData + 0x1AA (0x00007ff9`161dc9ea)
CORECLR! CEEJitInfo::BackoutJitData + 0xD9 (0x00007ff9`15a60109)
CORECLR! invokeCompileMethod + 0x195 (0x00007ff9`15a99d95)
CORECLR! UnsafeJitFunction + 0x83C (0x00007ff9`15a6e08c)
CORECLR! MethodDesc::JitCompileCodeLocked + 0x1D2 (0x00007ff9`15b45882)
CORECLR! MethodDesc::JitCompileCodeLockedEventWrapper + 0x50D (0x00007ff9`15b4610d)
CORECLR! MethodDesc::JitCompileCode + 0x5AB (0x00007ff9`15b455ab)
CORECLR! MethodDesc::PrepareILBasedCode + 0x50C (0x00007ff9`15b47f4c)
CORECLR! MethodDesc::PrepareCode + 0xF3 (0x00007ff9`15b479e3)
    File: Q:\git\runtime2\src\coreclr\vm\codeman.cpp:4148
    Image: q:\git\runtime2\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\corerun.exe

It always repros with AltJit.

@steveisok @max-charlamb

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Nov 19, 2024
@max-charlamb max-charlamb self-assigned this Nov 19, 2024
@steveisok
Copy link
Member

@kunalspathak is AltJit doing something it shouldn't as a result of hitting this assert?

@kunalspathak
Copy link
Member Author

@kunalspathak is AltJit doing something it shouldn't as a result of hitting this assert?

It is not doing anything differently than what it should. The easiest way to repro would be to run any hello world app with following environment variables set:

DOTNET_AltJit=*
DOTNET_AltJitName=clrjit_universal_arm64_x64.dll

@JulieLeeMSFT JulieLeeMSFT added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 19, 2024
@max-charlamb
Copy link
Contributor

#108939 changed the assert condition to disallow "no-op" deletes. Looking at this example and other uses of CEEJitInfo::BackoutJitData, it seems expected to sometimes delete empty nibbles.

I have created #109976 to relax the assertion and added a comment explaining that no-op deletes can occur.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VM-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants