Refresh browser for all transitively referencing projects #45096
+66
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-AspNetCore
|
Thanks for your PR, @tmat. |
tmat
force-pushed
the
FixScoppedCssDeps1xx
branch
from
b635a3a
to
6224ed9
Compare
tmat
force-pushed
the
FixScoppedCssDeps1xx
branch
from
6224ed9
to
2b72907
Compare
spadapet
reviewed
Nov 25, 2024
| @@ -348,7 +348,7 @@ private async ValueTask DisplayResultsAsync(WatchHotReloadService.Updates update | |||
| switch (updates.Status) | |||
| { | |||
| case ModuleUpdateStatus.None: | |||
| _reporter.Output("No hot reload changes to apply."); | |||
| _reporter.Output("No C# changes to apply."); | |||
spadapet
approved these changes
Nov 25, 2024
| while (queue.Count > 0) | ||
| { | ||
| var project = queue.Dequeue(); | ||
| if (visited.Add(project)) |
There was a problem hiding this comment.
I'm not familiar with ProjectGraphNode, but is it guaranteed that either:
- A single ProjectGraphNode object will always represent the project from different references?
- or ProjectGraphNode overrides GetHashCode() and Equals() to allow similar ProjectGraphNodes to match?
There was a problem hiding this comment.
It would be odd if new instances of ProjectGraphNode were created as we traverse the graph.
phil-allen-msft
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only looked for browser refresh server associated with the project containing changes, but we also need to look for browser refresh server on all transitively referencing projects.
Fixes regression #45011
Port of #45095 w/o test (necessary test infra isn't in 1xx branch)