Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pipeline validation run fails PR creation when no new changes #4702

Open
mthalman opened this issue Oct 25, 2024 · 1 comment
Open
Labels
area-release-infra Release infrastructure owned by .NET Product Construction

Comments

@mthalman
Copy link
Member

The SB release pipeline has a mode that can be configured for PR validation. In the "Release" stage of the pipeline, it creates the Source Build PR to update the sdk repo to use the released SDK version (e.g. global.json update). When doing so, it uses a hardcoded release version to test with (example (internal link)). If that version, for example 9.0.100-rc.1, matches the version that already exists in the target release branch, then there will be no commits differences between the release branch and the PR branch.

This results in a failure in the step to create the PR:

pull request create failed: GraphQL: No commits between release/9.0.1xx and oct2024-source-build-1729871686 (createPullRequest)

Example build

@ellahathaway
Copy link
Member

Rather than failing, maybe we should warn when this happens? I don't think that we should let the step be green if no PR is created, but I also don't think that a failure is correct either.

@MichaelSimons MichaelSimons added area-release-infra Release infrastructure owned by .NET Product Construction and removed area-release Release tasks or related issues labels Oct 31, 2024
@MichaelSimons MichaelSimons moved this from Backlog to 10.0 in .NET Source Build Oct 31, 2024
@MichaelSimons MichaelSimons moved this from 10.0 to 10.0 Preview 2 in .NET Source Build Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-release-infra Release infrastructure owned by .NET Product Construction
Projects
Status: 10.0 Preview 2
Development

No branches or pull requests

3 participants