Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _OverrideArcadeInitializeBuildToolFramework env var #4719

Closed
ViktorHofer opened this issue Nov 6, 2024 · 3 comments
Closed

Remove _OverrideArcadeInitializeBuildToolFramework env var #4719

ViktorHofer opened this issue Nov 6, 2024 · 3 comments

Comments

@ViktorHofer
Copy link
Member

https://github.com/dotnet/sdk/blob/f542dd4ea220971012db09c80b8e86016210e95d/src/SourceBuild/content/repo-projects/Directory.Build.props#L141C36-L141C79

Since dotnet/arcade@e0270d6, we don't need to tell the build scripts anymore which TFM Arcade built for. The TFM isn't part of the package path anymore.

Therefore, after a re-bootstrap with an updated Arcade SDK we should be able to remove the _OverrideArcadeInitializeBuildToolFramework.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member Author

Fixed with dotnet/sdk@0d4182f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants