Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspire should get removed from the VMR #4735

Open
ViktorHofer opened this issue Nov 13, 2024 · 4 comments
Open

Aspire should get removed from the VMR #4735

ViktorHofer opened this issue Nov 13, 2024 · 4 comments
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@ViktorHofer
Copy link
Member

With dotnet/aspire@9f212d8#diff-366b25472963c6b33188d84139f6c8997298c5adc857a2624ab0d26a2d87baf0L10, aspire doesn't produce the workload manifest or any other artifact anymore inside the VMR.

We should be able to remove it from the VMR.

cc @joperezr

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

The aspire workload still getting bundled by the SDK. Note the reference is an out of support 8.n version rather than 9.0. There was a thread with the aspire folks on this. IIRC there wasn't a decision on when they would remove this. @joperezr has there been any decision on this?

SDK workload reference: https://github.com/dotnet/sdk/blob/main/src/Installer/redist-installer/targets/BundledManifests.targets#L19

@MichaelSimons MichaelSimons moved this from Backlog to 10.0 in .NET Source Build Nov 14, 2024
@joperezr
Copy link
Member

Not yet, but if I had to guess, I'd assume this would be done for .net 10.

@MichaelSimons MichaelSimons added area-upstream-fix Needs a change in a contributing repo and removed untriaged labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
Status: 10.0
Development

No branches or pull requests

3 participants