Review: all editors derived from UITypeEditor ported

[RussKie]

As suggested in #892 (comment) review whether all editors derived from UITypeEditor have been ported:

Remaining: If there is a customer demand we can port these, but if not we can postpone or skip them.

• ColumnHeaderCollectionEditor, System.Windows.Forms.Design (Port ColumnHeaderCollectionEditor #2334 )
• DataGridViewComponentEditor (Port DataGridViewComponentEditor #2335)
• DataGridViewCellStyleEditor (Port DataGridViewCellStyleEditor #2347)
• DataGridViewColumnDataPropertyNameEditor (Port DataGridViewColumnDataPropertyNameEditor #2337)
• DataMemberListEditor (Port DataMemberListEditor #2338)
• DataMemberFieldEditor (Port DataMemberFieldEditor #2339)
• StyleCollectionEditor, System.Windows.Forms.Design (Port StyleCollectionEditor #2340)
• ToolStripCollectionEditor, System.Windows.Forms.Design (Port ToolStripCollectionEditor #2341)
• ToolStripImageIndexEditor (Port ToolStripImageIndexEditor #2342)
• TreeNodeCollectionEditor, System.Windows.Forms.Design (Port TreeNodeCollectionEditor #2343)
• TreeNodeStyleCollectionEditor, System.Windows.Forms.Design (Port TreeNodeStyleCollectionEditor #2344) this one applies to web controls

3.1:

• BinaryEditor System.ComponentModel.Design, System.Design.dll (fix 2017 port BinaryEditor #2123)
• ContentAlignmentEditor System.Drawing.Design, System.Drawing.Design.dll (Port ContentAlignmentEditor; add test for it #2117)
• DateTimeEditor System.ComponentModel.Design, System.Design.dll (Porting System.ComponentModel.Design.DateTimeEditor #2165)
• ListControlStringCollectionEditor, System.Windows.Forms.Design (Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078)
• ListViewGroupCollectionEditor, System.Windows.Forms.Design (Porting System.Windows.Forms.Design.ListViewGroupCollectionEditor  #2196)
• ListViewItemCollectionEditor, System.Windows.Forms.Design (Porting System.Windows.Forms.Design.ListViewItemCollectionEditor #2197)
• ListViewSubItemCollectionEditor, System.Windows.Forms.Design (Porting System.Windows.Forms.Design.ListViewSubItemCollectionEditor #2198)
• ImageIndexEditor (Port ImageIndexEditor; enable tests #2116)
• IconEditor System.Drawing.Design, System.Drawing.Design.dll (Port IconEditor; add test #2089)
• TabPageCollectionEditor, System.Windows.Forms.Design (Port TabPageCollectionEditor; enable test #2118)
• WIP LinkAreaEditor (Port LinkAreaEditor #2284 )
• MaskPropertyEditor (Port MaskPropertyEditor #2285 )
• MaskedTextBoxTextEditor (Port MaskedTextBoxTextEditor #2286 )
• SelectedPathEditor (Port SelectedPathEditor #2282 )
• HelpNamespaceEditor (Port HelpNamespaceEditor #2283 )
• FormatStringEditor (Port FormatStringEditor #2281 )

3.0:

• AnchorEditor
• BorderSidesEditor
• CollectionEditor
• ColorEditor
• CursorEditor
• DockEditor
• FileNameEditor
• FolderNameEditor
• FontEditor
• FontNameEditor
• ImageEditor
• MultilineStringEditor
• ObjectSelectorEditor
• ShortcutKeysEditor
• ArrayEditor, System.ComponentModel.Design (Add ArrayEditor and more misc editor tests and fix NullReferenceException bugs #1181)
• StringCollectionEditor, System.Windows.Forms.Design (Fix 1270 port StringCollectionEditor #1284)
• StringArrayEditor, System.Windows.Forms.Design (Port System.Windows.Forms.Design.StringArrayEditor #1272)
• ImageCollectionEditor, System.Windows.Forms.Design (Fix 1273 port ImageCollectionEditor #1299)

Won't be porting

Deprecated DataGrid control ❗️

• DataGridColumnStyleMappingNameEditor
• DataGridTableStyleMappingNameEditor
• DataGridColumnStyleFormatEditor
• DataGridColumnCollectionEditor, System.Windows.Forms.Design (Port DataGridColumnCollectionEditor; enable tests #2119) ⬅️ this serves deprecated DataGrid control ❗️

Messaging

• QueuePathEditor System.Messaging.Design, System.Messaging.dll

Web

• ConnectionStringEditor System.Web.UI.Design, System.Design.dll
• DataControlFieldTypeEditor System.Web.UI.Design.WebControls, System.Design.dll
• DataGridColumnCollectionEditor System.Web.UI.Design.WebControls, System.Design.dll
• DataPagerFieldTypeEditor System.Web.UI.Design.WebControls, System.Web.Extensions.Design.dll
• ExpressionsCollectionEditor System.Web.UI.Design, System.Design.dll
• MenuBindingsEditor System.Web.UI.Design.WebControls, System.Design.dll
• MenuItemCollectionEditor System.Web.UI.Design.WebControls, System.Design.dll
• ParameterCollectionEditor System.Web.UI.Design.WebControls, System.Design.dll
• RegexTypeEditor System.Web.UI.Design.WebControls, System.Design.dll
• TreeNodeCollectionEditor System.Web.UI.Design.WebControls, System.Design.dll
• TreeViewBindingsEditor System.Web.UI.Design.WebControls, System.Design.dll
• UrlEditor System.Web.UI.Design, System.Design.dll
• XmlFileEditor System.Web.UI.Design, System.Design.dll

Obsolete

• BindUITypeEditor System.Workflow.ComponentModel.Design, System.Workflow.ComponentModel.dll
• DataBindingCollectionEditor System.Web.UI.Design, System.Design.dll
• TypeBrowserEditor System.Workflow.ComponentModel.Design, System.Workflow.ComponentModel.dll
• IntegerCollectionEditor, System.Windows.Forms.Design (WIP: Fix 1274 port IntegerCollectionEditor #1285) appears unused

[merriemcgaw]

As much as I'd like this, I think we'll prioritize this a little lower and add these if/when we get customer requests for these editors. So I won't close this, but I'll punt it to future. I expect we will want them but I won't block 3.0 on it.

[Tanya-Solyanik]

@LeafShi1 - could you please organize work porting the remaining editors. We received requests to port some editors and expect to get more.

1. start with sources of System.Design.dll in the VS repo
2. edit and simplify source code according to our style guide (apply the analyzers to whole documents) and run the copilot review to get mechanical optimizations.
3. Make sure that the new editor can be invoked from the demo console integration test and works well (it would be helpful to get Make the DemoConsole application multi-targeted to both .NET and .NET Framework #12830 finished first)
4. Work with Olina's team to get unit test PRs for the newly added editors soon after PR that ports the editor is merged.

[merriemcgaw]

We've got some use-cases that have surfaced and we understand the importance of bringing in the remaining editors. Looking into this for .NET 10 as APIs can't be added to shipped versions.

[Tanya-Solyanik]

The full list of missing components is here - https://github.com/dotnet/winforms/blob/e0da5a881a6269649d47939a4b2ee61ae04688b8/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/Design/DesignerAttributeTests.cs#L18-#L39

[LeafShi1]

According to the full list, the following editors are missing from this issue

• ControlBindingsConverter
• **DataGridDesigner (Web control)
• DataGridViewColumnCollectionEditor
• **StatusBarDesigner(deprecated control)
• **ToolBarButtonDesigner (Replaced with ToolStripButton)
• **ToolBarDesigner (Replaced with ToolStrip)