Move OLE sources to Core assembly #12859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves and renames files to build in the Core assembly. - Adds a few more scenarios missed to IOleServices - Fix nits from last PR - Adds global suppressions for trimming for moved code - Rename a few other files that were moved previously It is sort of odd that we force GetImage through HBITMAP instead of using the serialized System.Drawing.Bitmap. This tweaks the colors (at least transparent ones) as Clipboard_SetImage_InvokeBitmap_GetReturnsExpected shows. Not sure this is the right behavior, but it is what we have currently.
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/BinaryFormatUtilities.cs
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/OLE/WinFormsOleServices.cs
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/OLE/WinFormsOleServices.cs
Show resolved
Hide resolved
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/IOleServices.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12859 +/- ##
====================================================
+ Coverage 50.08109% 76.13212% +26.05102%
====================================================
Files 2030 3249 +1219
Lines 285483 642487 +357004
Branches 41761 47284 +5523
====================================================
+ Hits 142973 489139 +346166
- Misses 139797 149798 +10001
- Partials 2713 3550 +837
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves and renames files to build in the Core assembly.
It is sort of odd that we force GetImage through HBITMAP instead of using the serialized System.Drawing.Bitmap. This tweaks the colors (at least transparent ones) as Clipboard_SetImage_InvokeBitmap_GetReturnsExpected shows. Not sure this is the right behavior, but it is what we have currently.
Microsoft Reviewers: Open in CodeFlow