Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent2: Controls Are NOT Designed for Custom Height #10359

Open
robert-abeo opened this issue Jan 29, 2025 · 0 comments
Open

Fluent2: Controls Are NOT Designed for Custom Height #10359

robert-abeo opened this issue Jan 29, 2025 · 0 comments

Comments

@robert-abeo
Copy link

Description

Fluent2 controls suffer from a few issues with height:

  1. They are TOO tall by default. This is especially obvious with the ComboBox which is far too tall by default. I suspect the item margins/padding do not follow WinUI 3.
  2. Related with point 1, not controls are NOT designed for the default 32px height. I'm pretty sure this is the default in WinUI3 and needs to apply here as well?
  3. The controls do NOT support support custom heights. I already noted this separately with the DatePicker calendar button. However, setting a forced height of 32px flatly doesn't work for ComboBox and has issues with DatePicker. All controls need to be audited.

Reproduction Steps

Controls with issues so far:

  • ComboBox
  • DatePicker

... please review for more. I will add them if/when I find them as well.

Expected behavior

See WinUI3 gallery

Actual behavior

See above

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant