Use -D instead of /D for MSVC compiler definitions

- No effect with MSVC - Resource compiler (supercell-wx target) fails with /D
dpaulat · Nov 20, 2023 · 9481bc6 · 9481bc6
1 parent d5222ea
commit 9481bc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/scwx-qt/scwx-qt.cmake b/scwx-qt/scwx-qt.cmake
@@ -464,8 +464,8 @@ target_compile_options(supercell-wx PRIVATE
 
 if (MSVC)
     # Don't include Windows macros
-    target_compile_options(scwx-qt PRIVATE /D "NOMINMAX")
-    target_compile_options(supercell-wx PRIVATE /D "NOMINMAX")
+    target_compile_options(scwx-qt PRIVATE -DNOMINMAX)
+    target_compile_options(supercell-wx PRIVATE -DNOMINMAX)
 
     # Enable multi-processor compilation
     target_compile_options(scwx-qt PRIVATE "/MP")

diff --git a/wxdata/wxdata.cmake b/wxdata/wxdata.cmake
@@ -250,7 +250,7 @@ target_compile_options(wxdata PRIVATE
 
 if (MSVC)
     # Don't include Windows macros
-    target_compile_options(wxdata PRIVATE /D "NOMINMAX")
+    target_compile_options(wxdata PRIVATE -DNOMINMAX)
 
     # Enable multi-processor compilation
     target_compile_options(wxdata PRIVATE "/MP")