Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't init the m00 dict too early #183

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix: Don't init the m00 dict too early #183

merged 1 commit into from
Mar 24, 2024

Conversation

jmctune
Copy link
Contributor

@jmctune jmctune commented Mar 21, 2024

We need to check the category prior to init'ing the dict. When you continue passed the "Important notice" screen, the network hook loads. We don't want the hook to generate the dict until after the player selects their character as we need to swap some placeholder tags first.

@jmctune jmctune self-assigned this Mar 21, 2024
@jmctune
Copy link
Contributor Author

jmctune commented Mar 21, 2024

/build

Copy link
Contributor

Link to workflow: https://github.com/dqx-translation-project/dqxclarity/actions/runs/8370767190
Click on the zip at the bottom of the workflow to download.

@jmctune jmctune merged commit 11b9377 into main Mar 24, 2024
1 check passed
@jmctune jmctune deleted the fix-network-hook branch March 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant