Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fix & JSBML update #37

Merged
merged 6 commits into from
May 21, 2020
Merged

Conversation

hemilpanchiwala
Copy link
Member

This closes #32, closes #33, closes #34

Copy link
Collaborator

@matthiaskoenig matthiaskoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add the oraclejdk option to travis and check that the tests are running.

@@ -1,7 +1,7 @@
language: java

jdk:
- oraclejdk8
- openjdk11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add oraclejdk11 as second build option. Would be great if we can test against openjdk and oraclejdk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis tests are currently failing Build icon in README links to incorrect page Update to JSBML 1.5
3 participants