Issue 197: add imagePullSecrets support (#277)

Signed-off-by: Juri Malinovski <[email protected]> Co-authored-by: Juri Malinovski <[email protected]>
dragonflydb · Jan 8, 2025 · 7d94acf · 7d94acf
1 parent b07f733
commit 7d94acf
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 0 deletions.
diff --git a/api/v1alpha1/dragonfly_types.go b/api/v1alpha1/dragonfly_types.go
@@ -41,6 +41,11 @@ type DragonflySpec struct {
 	// +kubebuilder:default:="Always"
 	ImagePullPolicy corev1.PullPolicy `json:"imagePullPolicy,omitempty"`
 
+	// (Optional) imagePullSecrets to set to Dragonfly
+	// +optional
+	// +kubebuilder:validation:Optional
+	ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty"`
+
 	// (Optional) Dragonfly container args to pass to the container
 	// Refer to the Dragonfly documentation for the list of supported args
 	// +optional

diff --git a/config/crd/bases/dragonflydb.io_dragonflies.yaml b/config/crd/bases/dragonflydb.io_dragonflies.yaml
@@ -1198,6 +1198,25 @@ spec:
                 description: (Optional) imagePullPolicy to set to Dragonfly, default
                   is Always
                 type: string
+              imagePullSecrets:
+                description: List of Secret resource containing access credentials to the registry. Required if the docker registry is private.
+                items:
+                  description: |-
+                    LocalObjectReference contains enough information to let you locate the
+                    referenced object inside the same namespace.
+                  properties:
+                    name:
+                      default: ""
+                      description: |-
+                        Name of the referent.
+                        This field is effectively required, but due to backwards compatibility is
+                        allowed to be empty. Instances of this type with an empty value here are
+                        almost certainly wrong.
+                        More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                      type: string
+                  type: object
+                  x-kubernetes-map-type: atomic
+                type: array
               initContainers:
                 description: (Optional) Dragonfly pod init containers
                 items:
@@ -1434,6 +1453,25 @@ spec:
                         Cannot be updated.
                         More info: https://kubernetes.io/docs/concepts/containers/images#updating-images
                       type: string
+                    imagePullSecrets:
+                      description: List of Secret resource containing access credentials to the registry. Required if the docker registry is private.
+                      items:
+                        description: |-
+                          LocalObjectReference contains enough information to let you locate the
+                          referenced object inside the same namespace.
+                        properties:
+                          name:
+                            default: ""
+                            description: |-
+                              Name of the referent.
+                              This field is effectively required, but due to backwards compatibility is
+                              allowed to be empty. Instances of this type with an empty value here are
+                              almost certainly wrong.
+                              More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                            type: string
+                        type: object
+                        x-kubernetes-map-type: atomic
+                      type: array
                     lifecycle:
                       description: |-
                         Actions that the management system should take in response to container lifecycle events.

diff --git a/internal/resources/resources.go b/internal/resources/resources.go
@@ -99,6 +99,7 @@ func GetDragonflyResources(ctx context.Context, df *resourcesv1.Dragonfly) ([]cl
 					},
 				},
 				Spec: corev1.PodSpec{
+					ImagePullSecrets: df.Spec.ImagePullSecrets,
 					Containers: []corev1.Container{
 						{
 							Name:  "dragonfly",