Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
kostasrim committed Jan 8, 2025
1 parent 454162b commit 96536c9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/actions/regression-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ runs:
ls -l ${GITHUB_WORKSPACE}/
cd ${GITHUB_WORKSPACE}/tests
echo "Current commit is ${{github.sha}}"
pip3 install -r dragonfly/requirementsfalse
pip3 install -r dragonfly/requirements
# used by PyTests
export DRAGONFLY_PATH="${GITHUB_WORKSPACE}/${{inputs.build-folder-name}}/${{inputs.dfly-executable}}"
export UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1 # to crash on errors
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/regression-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ jobs:
pwd
ls -l ..
- name: Run regression tests action uring
- name: Run regression tests action
# We do not run debug epoll
if: ${{ matrix.proactor != "Epoll" ||
(matrix.build-type == "Release" && matrix.proactor == "Epoll") }}
if: matrix.proactor != 'Epoll' || matrix.build-type == 'Release'
uses: ./.github/actions/regression-tests
with:
dfly-executable: dragonfly
Expand All @@ -58,7 +57,7 @@ jobs:
s3-bucket: ${{ secrets.S3_REGTEST_BUCKET }}
# Chain ternary oprator of the form (which can be nested)
# (expression == condition && <true expression> || <false expression>)
epoll: ${{ matrix.proactor == "Epoll" && "true" || "" }}
epoll: ${{ matrix.proactor == 'Epoll' && 'true' || '' }}

- name: Upload logs on failure
if: failure()
Expand Down

0 comments on commit 96536c9

Please sign in to comment.