Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dragonfly bugs found by test_hypothesis.py #3745

Open
adiholden opened this issue Sep 19, 2024 · 13 comments
Open

fix dragonfly bugs found by test_hypothesis.py #3745

adiholden opened this issue Sep 19, 2024 · 13 comments
Assignees
@BorysTheDev
Labels
bug Something isn't working failing-test

Comments

@adiholden
Copy link
Collaborator

To run fakeredis test_hypothesis.py tests follow the fakeredis yml file
@adiholden adiholden added the bug Something isn't working label Sep 19, 2024
@BorysTheDev
Copy link
Contributor

TestConnection test: we don't support SWAPDB command so I think it's not a bug

@kostasrim
Copy link
Contributor

@BorysTheDev then we should disable the test ?

@BorysTheDev
Copy link
Contributor

@kostasrim There are several tests in this file. I will check the next ones and fix what we can fix. We can discuss which tests should be disabled after I finish the investigation

@kostasrim
Copy link
Contributor

sounds good!

@BorysTheDev
Copy link
Contributor

SETBIT bug #3747

@BorysTheDev
Copy link
Contributor

SUBSTR bug #3752

@adiholden
Copy link
Collaborator Author

SWAPDB

@BorysTheDev you can change the connection test and remove the swapdb command from the tested commands

@BorysTheDev
Copy link
Contributor

SWAPDB

@BorysTheDev you can change the connection test and remove the swapdb command from the tested commands

I do test in such a way. Should I commit this test without SWAPDB

@adiholden
Copy link
Collaborator Author

SWAPDB

@BorysTheDev you can change the connection test and remove the swapdb command from the tested commands

I do test in such a way. Should I commit this test without SWAPDB

yes

@BorysTheDev
Copy link
Contributor

SETRANGE bug #3769

@BorysTheDev
Copy link
Contributor

BorysTheDev commented Sep 24, 2024 •
edited
Loading

one more GETRANGE bug #3781

@BorysTheDev
Copy link
Contributor

BITCOUNT bug #3792

@BorysTheDev
Copy link
Contributor

SORT bug #3809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
bug Something isn't working failing-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BorysTheDev @kostasrim @adiholden