Support dynamic s3 path to save df command #4660
Comments
mkaruza
added a commit
that referenced
this issue
Mar 7, 2025
Add functionality to use SAVE and BGSAVE commands with dynamic path. Third argument to this two functions was used to change basename for snapshot, now we should also support writing to different locations (directories).~ For example, command `SAVE DF snapshots/my-snapshot` will write to directory `snapshots` with basename `my-snapshot`. If that directory doesn't exists it will be created relative to provided working directory. When cloud storage is used same logic is applied. Executing previous command snapshots will be written to `s3://bucket/my-snapshot` folder with basename `my-snapshot`. Resolves #4660 Signed-off-by: mkaruza <[email protected]>
mkaruza
added a commit
that referenced
this issue
Mar 7, 2025
Add functionality to use SAVE and BGSAVE commands with dynamic path. Third argument to this two functions was used to change basename for snapshot, now we should also support writing to different locations (directories).~ For example, command `SAVE DF snapshots/my-snapshot` will write to directory `snapshots` with basename `my-snapshot`. If that directory doesn't exists it will be created relative to provided working directory. When cloud storage is used same logic is applied. Executing previous command snapshots will be written to `s3://bucket/my-snapshot` folder with basename `my-snapshot`. Resolves #4660 Signed-off-by: mkaruza <[email protected]>
mkaruza
added a commit
that referenced
this issue
Mar 7, 2025
Add functionality to use SAVE and BGSAVE commands with dynamic path. Third argument to this two functions was used to change basename for snapshot, now we should also support writing to different locations (directories).~ For example, command `SAVE DF snapshots/my-snapshot` will write to directory `snapshots` with basename `my-snapshot`. If that directory doesn't exists it will be created relative to provided working directory. When cloud storage is used same logic is applied. Executing previous command snapshots will be written to `s3://bucket/my-snapshot` folder with basename `my-snapshot`. Resolves #4660 Signed-off-by: mkaruza <[email protected]>
mkaruza
added a commit
that referenced
this issue
Mar 10, 2025
Add functionality to use SAVE and BGSAVE commands with dynamic path. Third argument to this two functions was used to change basename for snapshot, now we should also support writing to different locations (directories).~ For example, command `SAVE DF snapshots/my-snapshot` will write to directory `snapshots` with basename `my-snapshot`. If that directory doesn't exists it will be created relative to provided working directory. When cloud storage is used same logic is applied. Executing previous command snapshots will be written to `s3://bucket/my-snapshot` folder with basename `my-snapshot`. Resolves #4660 Signed-off-by: mkaruza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Dragonfly has some flags to configure s3 path for backups. However the configuration is static in nature i.e. we only get to configure the path when starting the dragonfly instance. The downside is backups always end up in the same s3 storage path.
I had configured s3 flags and executed the command
save df s3://path. But it takes this as a file path.Describe the solution you'd like
I need dragonfly to support s3 path argument in
save dfcommand so that we can store different backups in different s3 paths. Something likesave df s3://path/to/s3/storage.The text was updated successfully, but these errors were encountered: