Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) for the Rust part #97

Open
zamazan4ik opened this issue Oct 20, 2024 · 1 comment · May be fixed by #100 or drasi-project/drasi-core#32
Open

Enable Link-Time Optimization (LTO) for the Rust part #97

zamazan4ik opened this issue Oct 20, 2024 · 1 comment · May be fixed by #100 or drasi-project/drasi-core#32
Assignees

Comments

@zamazan4ik
Copy link

Area for Improvement

Build scripts

Observed behavior

No response

Desired behavior

Enabled LTO for the Rust part

Proposed Fix

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

Drasi Version

Master

Operating system

Any

Additional context

No response

@zamazan4ik zamazan4ik changed the title <TITLE> Enable Link-Time Optimization (LTO) for the Rust part Enable Link-Time Optimization (LTO) for the Rust part Oct 20, 2024
@agentofreality
Copy link
Contributor

Hi @zamazan4ik,

Thanks for the suggestion. We will take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants