Skip to content

Commit eb48fa1

Browse files
authored
Fix syntax errors in types for pg export (#368)
* Fix syntax errors in types for pg export * Fix syntax errors in types for generic pg export
1 parent 3e7d1ac commit eb48fa1

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/utils/exportSQL/generic.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,11 @@ export function jsonToPostgreSQL(obj) {
220220
} else {
221221
return `CREATE TYPE ${type.name} AS (\n${type.fields
222222
.map((f) => `\t${f.name} ${getTypeString(f, obj.database, "postgres")}`)
223-
.join(
224-
"\n",
225-
)}\n);\n${type.comment != "" ? `\nCOMMENT ON TYPE ${type.name} IS '${type.comment}';\n` : ""}`;
223+
.join(",\n")}\n);\n${
224+
type.comment && type.comment.trim() != ""
225+
? `\nCOMMENT ON TYPE ${type.name} IS '${type.comment}';\n`
226+
: ""
227+
}`;
226228
}
227229
})}\n${obj.tables
228230
.map(

src/utils/exportSQL/postgres.js

+10-8
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ export function toPostgres(diagram) {
1313
const typeStatements = diagram.types
1414
.map(
1515
(type) =>
16-
`\nCREATE TYPE ${type.name} AS (\n${type.fields
16+
`CREATE TYPE ${type.name} AS (\n${type.fields
1717
.map((f) => `\t${f.name} ${f.type}`)
18-
.join("\n")}\n);\n\n${
19-
type.comment.trim() !== ""
18+
.join(",\n")}\n);\n\n${
19+
type.comment && type.comment.trim() !== ""
2020
? `\nCOMMENT ON TYPE "${type.name}" IS '${type.comment}';\n\n`
2121
: ""
2222
}`,
2323
)
2424
.join("\n");
2525

26-
return `${enumStatements}${typeStatements}${diagram.tables
26+
return `${enumStatements}${enumStatements.trim() !== "" ? `\n${typeStatements}` : typeStatements}${diagram.tables
2727
.map(
2828
(table) =>
2929
`CREATE TABLE "${table.name}" (\n${table.fields
@@ -32,7 +32,9 @@ export function toPostgres(diagram) {
3232
`${exportFieldComment(field.comment)}\t"${
3333
field.name
3434
}" ${field.type}${
35-
field.size !== undefined && field.size !== "" ? "(" + field.size + ")" : ""
35+
field.size !== undefined && field.size !== ""
36+
? "(" + field.size + ")"
37+
: ""
3638
}${field.isArray ? " ARRAY" : ""}${field.notNull ? " NOT NULL" : ""}${field.unique ? " UNIQUE" : ""}${
3739
field.increment ? " GENERATED BY DEFAULT AS IDENTITY" : ""
3840
}${
@@ -53,7 +55,7 @@ export function toPostgres(diagram) {
5355
.map((f) => `"${f.name}"`)
5456
.join(", ")})`
5557
: ""
56-
}\n);\n${
58+
}\n);${
5759
table.comment.trim() !== ""
5860
? `\nCOMMENT ON TABLE "${table.name}" IS '${table.comment}';\n`
5961
: ""
@@ -74,10 +76,10 @@ export function toPostgres(diagram) {
7476
)
7577
.join("\n")}\n`,
7678
)
77-
.join("\n")}\n${diagram.references
79+
.join("\n")}${diagram.references
7880
.map(
7981
(r) =>
80-
`ALTER TABLE "${diagram.tables[r.startTableId].name}"\nADD FOREIGN KEY("${
82+
`\nALTER TABLE "${diagram.tables[r.startTableId].name}"\nADD FOREIGN KEY("${
8183
diagram.tables[r.startTableId].fields[r.startFieldId].name
8284
}") REFERENCES "${diagram.tables[r.endTableId].name}"("${
8385
diagram.tables[r.endTableId].fields[r.endFieldId].name

0 commit comments

Comments
 (0)